SNOW-1820480 making OCSP validation code more resillient #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One user who was encountering this issue has tested this fix |
sfc-gh-mkeller
added
the
DO_NOT_PORT_CHANGES_TO_SP
sfc-gh-wshangguan
approved these changes
Nov 25, 2024
Comment on lines
+375
to
+384
| additional_kwargs: dict[str, typing.Any] = dict() | ||
| if isinstance(public_key, RSAPublicKey): | ||
| additional_kwargs["padding"] = padding.PKCS1v15() | ||
| additional_kwargs["algorithm"] = utils.Prehashed(chosen_hash) | ||
| elif isinstance(public_key, DSAPublicKey): | ||
| additional_kwargs["algorithm"] = utils.Prehashed(chosen_hash) | ||
| elif isinstance(public_key, EllipticCurvePublicKey): | ||
| additional_kwargs["signature_algorithm"] = ECDSA( | ||
| utils.Prehashed(chosen_hash) | ||
| ) |
There was a problem hiding this comment.
This fix covers more than the issue reported by the user?
There was a problem hiding this comment.
No, only the reported issue. TypeError is raised in the case where we send in too many arguments to the verify() call.
sfc-gh-fhe
reviewed
Nov 25, 2024
| @@ -11,6 +11,7 @@ Source code is also available at: https://github.com/snowflakedb/snowflake-conne | |||
| - v3.12.4(TBD) | |||
There was a problem hiding this comment.
Unless you can tell me when the next release is happening yes
sfc-gh-mkeller
deleted the
mkeller/SNOW-1820480/OCSP-verification-arguments
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1774037: OCSP check fails when execption is not of type RevocationCheckError #2094
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
I try to make the code that calls into cryptography more resilient against TypeErrors.
(Optional) PR for stored-proc connector: