Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1490901 Passcode support for mfa authentication #979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1490901 Passcode support for mfa authentication

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner June 21, 2024 21:25
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.66%. Comparing base (393762a) to head (434b03d).

Files Patch % Lines
...Core/Authenticator/ExternalBrowserAuthenticator.cs 0.00% 1 Missing ⚠️
...nowflake.Data/Core/Authenticator/IAuthenticator.cs 93.33% 0 Missing and 1 partial ⚠️
...ke.Data/Core/Authenticator/KeyPairAuthenticator.cs 0.00% 1 Missing ⚠️
Snowflake.Data/Core/RestRequest.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage   85.58%   85.66%   +0.07%     
==========================================
  Files         106      106              
  Lines       10759    10803      +44     
  Branches     1029     1034       +5     
==========================================
+ Hits         9208     9254      +46     
+ Misses       1303     1299       -4     
- Partials      248      250       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant