Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki pages corrections #275

Open
impeeza opened this issue Oct 3, 2023 · 1 comment
Open

Wiki pages corrections #275

impeeza opened this issue Oct 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@impeeza
Copy link

impeeza commented Oct 3, 2023

Describe your bug here. And how to reproduce it.

Hello there,

With the latest change on the code, the Wiki pages get outdated, there are small things but could create confusion on the people trying to build the repo.

On the page https://github.com/snesrev/zelda3/wiki/1.-Getting-Started

On the section MSYS you are missing the next packages which are needed to build on that environment:

  • git
  • make
  • mingw-w64-x86_64-python
  • mingw-w64-x86_64-SDL2

On page https://github.com/snesrev/zelda3/wiki/2.-Cloning-and-Setup

The paragraph

go into the zelda3 folder, then inside the tables folder place your zelda3.sfc rom

now should be

go into the zelda3 folder and place your zelda3.sfc rom there

below,

The text:

return to the Git Bash window (or MSYS2)

type: cd zelda3/tables
type: python restool.py --extract-from-rom

Now should be changed to:

return to the Git Bash window (or MSYS2)
type: cd zelda3/
type: python assets/restool.py --extract-from-rom

Also on Multi-Language Support

The text:

Rename your German Rom to German.sfc and place it in the tables folder, you should still have the separate zelda3.sfc also

run these two commands

python restool.py --extract-dialogue -r german.sfc

then

python restool.py --languages=de

you should now have dialogue_de.txt and font_de.png fils

now should be something like:

Rename your German Rom to German.sfc and place it in the root folder, you should still have the separate zelda3.sfc also

run these two commands

python assets/restool.py --extract-dialogue -r german.sfc

then

python assets/restool.py --extract-from-rom --languages=de

you should now have dialogue_de.txt and font_de.png files

the last line have a little typo, files is missing a «e»

By the way on the wiki there are no the Checksum of the supported ROMS for each language.

What is your build target?

Windows

@impeeza impeeza added the bug Something isn't working label Oct 3, 2023
@impeeza
Copy link
Author

impeeza commented Oct 19, 2023

Hello there, I am pinning @snesrev on this issue in order to know if there is something to improve on the issue, and/or PR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant