-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add statements to delegates list #641
Conversation
Can't see any commit |
Weird, can not find the commit, will do it again 😒 |
Waiting for #647 to also strip all html tags from the statement excerpt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not click on the dropdown menu item like "Delegate". Otherwise it looks good
Isn't the "View profile" menu redundant, since the whole link is clickable ? |
Fixed by having multiple different link by column, instead of one single link for the whole row. Minor inconvenient is that the little gap between column is not clickable. Better than to have a single link, with the dropdown menu inside the link, and have to add a |
Did you tried to have 1 link that group the whole line expect 3 dot menu? |
Seems to work, without breaking the flex column |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/174
This PR adds a new
statement
column in the space delegates list, as well as a sub-menu for each row, with a link to:Note
remove-markdown
dependency to strip all markdown code from statement excerptHow to test
Statement
column, showing the delegatee statement on 2 lines maximum...
button, on each line far right, with a dropdown menuView profile
menu should redirect to this delegatee space user profileSee on block explorer
should open this delegatee address on the block explorer