Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to ofetch #904
base: master
Are you sure you want to change the base?
Migrate to ofetch #904
Changes from 6 commits
1c2f3d9
0304356
60faabe
bf0c869
170b932
b212168
a910087
3dc29cb
6bc962f
77a6c2f
cfd5246
fc18bab
836dddf
bc64032
137ffa1
2cb0b93
925f2b8
ba1889c
83981d4
1610b3d
305935b
bfad8f7
3bb41c9
3d1dc2a
dbc44e0
261a6e4
58fc436
520b95e
96d7df1
93f8069
bec2e3a
b2cc4b2
cfb0e3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume sometimes a successful response could look like this:
Also, consider that the
getVp
function returned the result ifbody.result
otherwise it returnedundefined
. It can be an error from the past, but better to checkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, no 200 response should ever return an object with the
error
keyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean after this line it returns nothing(
undefined
). But your implementation always returns data. As I said, it could be an error in the previous version, but better to check in places where we usegetVp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're reading the wrong commit, the line you're mentioning have been removed