feat: Add env BROVIDER_URL #1089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaituVR
reviewed
Nov 29, 2024
| @@ -1,3 +1,4 @@ | |||
| import 'dotenv/config'; | |||
There was a problem hiding this comment.
Not sure if we want to use this on front end, it works?
ChaituVR
reviewed
Nov 29, 2024
| @@ -10,7 +11,7 @@ export type ProviderOptions = { | |||
| broviderUrl?: string; | |||
| }; | |||
|
|
|||
| const DEFAULT_BROVIDER_URL = 'https://rpc.snapshot.org'; | |||
| const DEFAULT_BROVIDER_URL = process.env.BROVIDER_URL || 'https://rpc.snapshot.org'; | |||
There was a problem hiding this comment.
Which project is asking for this?
There was a problem hiding this comment.
https://github.com/snapshot-labs/snapshot-strategies/blob/master/src/utils/vp.ts#L22
I'm using getVp, but I want to use my own provider rpc.
So change getProvider in snapshot.js.
Another solution: ADD setBroviderUrl #1090
let DEFAULT_BROVIDER_URL = 'https://rpc.snapshot.org';
export function setBroviderUrl(broviderUrl: string) {
DEFAULT_BROVIDER_URL = broviderUrl;
}
Link: EthanOK@485948a
I am more in favor of add setBroviderUrl. You can close add env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this pull request: