fix: always return out-of-range error, regardless of proposal state

snapshot-labs · Jan 16, 2024 · f5f90ae · f5f90ae
1 parent d04b67a
commit f5f90ae
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/scores.ts b/src/scores.ts
@@ -182,9 +182,11 @@ export async function updateProposalAndVotes(proposalId: string, force = false)
         `[scores] Proposal updated ${proposal.id}, ${proposal.space}, ${results.scores_state}, ${votes.length}`
       );
     } catch (e: any) {
-      if (proposal.state === 'closed' && e.code === 'ER_WARN_DATA_OUT_OF_RANGE') {
+      if (e.code === 'ER_WARN_DATA_OUT_OF_RANGE') {
         log.info(`[scores] Invalid final scores_total: ${results.scores_total}`, e);
-        await invalidateProposalScore(proposalId);
+        if (proposal.state === 'closed') {
+          await invalidateProposalScore(proposalId);
+        }
         throw new Error('Invalid out of range score');
       } else {
         throw e;