Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

props.env is undefined #14

Open
revmischa opened this issue Oct 8, 2020 · 3 comments
Open

props.env is undefined #14

revmischa opened this issue Oct 8, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@revmischa
Copy link
Contributor

Not sure how to get AWS account ID or region - props.env is undefined

image
@RichardDRJ
Copy link
Contributor

Good point! Right now, we don't set env on props - happy to take a look at doing it at some point or accept a PR to add it. In the meantime, I've updated the README in #16 with an example of how you can get account ID, region, and any other information the aws-cdk provider has.

@RichardDRJ RichardDRJ added enhancement New feature or request good first issue Good for newcomers labels Oct 9, 2020
@revmischa
Copy link
Contributor Author

serverless-stack has a nice helper function to get a prefixed resource name: https://github.com/serverless-stack/serverless-stack/tree/master/packages/resources#prefixing-resource-names
might be some other good ideas to steal from that module

@revmischa
Copy link
Contributor Author

Screen Shot 2020-10-10 at 10 27 01 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@revmischa @RichardDRJ