Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tera Shell quarters the damage if its owner has two Types #10674

Open
Nihilslave opened this issue Nov 11, 2024 · 0 comments
Open

Tera Shell quarters the damage if its owner has two Types #10674

Nihilslave opened this issue Nov 11, 2024 · 0 comments

Comments

@Nihilslave
Copy link

https://replay.pokemonshowdown.com/gen9doublesubers-2241672756-ryty01dj1vypoy3fcftnjbrdri1mzxopw
As you can see in the replay Terapagos gets an additional Grass Type by Forest's Curse. And then when Tera Shell activates it 4x resists the move instead of 2x, which shouldn't be a correct behaviour compared to real game I believe.
This is caused by Pokemon.runEffectiveness() which iters through all types of a Pokemon and for each loop it triggers onEffectiveness() of Tera Shell. And when there are more than 1 Types, Tera Shell's effect (i.e. onEffectiveness()) will be triggered more than 1 times.
I make this an issue but not a pull request because 1. I'm not sure how it really works in real game, and 2. I also don't know how to fix it in an elegant way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant