Improper regex usage in the proto-gen getRelativeTypeName method

[eggp]

Current code:
https://github.com/smnbbrv/ngx-grpc/blob/master/packages/protoc-gen-ng/src/input/proto.ts#L132

When generating my own proto, the pbType becomes: .Profiles.Operation
The regex fails on this because it is incorrect.

Fixed regex:
pbType.match(/^\.(([A-Za-z0-9._]*)\.)?([A-Za-z0-9._]+$)/)

Uppercase letters also need to be included.

[eggp]

I will correct it myself and show the solution I believe is correct, where only the package name is removed because the rest is needed, and this way my complex proto messages will translate correctly.

  getRelativeTypeName(pbType: string, thisProtoPackageName = '') {
    Services.Logger.debug(`Getting relative type "${pbType}" name from package "${thisProtoPackageName}"`);

    const meta = this.resolveTypeMetadata(pbType);
    // const [, , /* packageName */, typeName] = pbType.match(/^\.(([a-z0-9._]*)\.)?([A-Za-z0-9._]+$)/) as RegExpMatchArray;
    const typeName = this.removePackageName(pbType);

    if (meta.proto === this) {
      return (thisProtoPackageName ? thisProtoPackageName + '.' : '') + typeName;
    }

    return this.getDependencyPackageName(meta.proto) + '.' + typeName;
  }

  removePackageName(input:string) {
    const parts = input.split('.');
    if (parts.length > 2) {
      return parts.slice(2).join('.');
    }
    return input;
  }

In the future, when I have time, I will create a demo proto directory to showcase the error and the results of the corrected code.

[eggp]

I create a example repository:

https://github.com/eggp/ngx-grpc-issue-113

Directories:

• proto => example complex proto
• generated_wrong => Compiled with the current version.
• generated_good => Compiled with fixed code

[smnbbrv]

This was already reported some time ago I think. Having uppercase characters in package names is not recommended however:

https://protobuf.dev/programming-guides/style/#packages

Package names should be in lowercase. Package names should have unique names based on the project name, and possibly based on the path of the file containing the protocol buffer type definitions.

[eggp]

This was already reported some time ago I think. Having uppercase characters in package names is not recommended however:

https://protobuf.dev/programming-guides/style/#packages

Package names should be in lowercase. Package names should have unique names based on the project name, and possibly based on the path of the file containing the protocol buffer type definitions.

This is valid and I understand, but couldn't a switch be integrated into the compiler?