Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reqired products are added to cart without respect for ACL, Store Restrictions or even asking if the product is published #1244

Open
Michael-Herzog opened this issue Jan 10, 2025 · 1 comment
Open

Reqired products are added to cart without respect for ACL, Store Restrictions or even asking if the product is published #1244

Michael-Herzog opened this issue Jan 10, 2025 · 1 comment
Assignees
@mgesing @Michael-Herzog
Labels
bug low
Milestone
6.0.1

Comments

@Michael-Herzog
Copy link
Contributor

ShoppingCartService > AddRequiredProductsAsync
@Michael-Herzog Michael-Herzog added this to the 6.0.1 milestone Jan 10, 2025
@mgesing mgesing added the low label Jan 10, 2025
@mgesing
Copy link
Contributor

mgesing commented Jan 10, 2025 •
edited
Loading

Avoidable. The admin specifies which product is required. It would therefore be a check to see if the admin has made a mistake in his configuration.

AddRequiredProductsAsync should not check anything, but only realize the configuration of the admin. Checks must only take place in the ShoppingCartValidator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgesing mgesing

@Michael-Herzog Michael-Herzog

Labels
bug low
Projects
None yet
Milestone
6.0.1
Development

No branches or pull requests
2 participants
@mgesing @Michael-Herzog