From 325fb1241a834929b70f9c893b5ccd8ad96b1055 Mon Sep 17 00:00:00 2001 From: James Walker Date: Fri, 5 Jan 2024 09:34:02 -0500 Subject: [PATCH] remove testing since this will be in future work --- core/chains/tx_store_test.go | 142 ----------------------------------- 1 file changed, 142 deletions(-) delete mode 100644 core/chains/tx_store_test.go diff --git a/core/chains/tx_store_test.go b/core/chains/tx_store_test.go deleted file mode 100644 index c1fc3383d0a..00000000000 --- a/core/chains/tx_store_test.go +++ /dev/null @@ -1,142 +0,0 @@ -package chains_test - -import ( - "context" - "fmt" - "math/big" - "testing" - "time" - - "github.com/ethereum/go-ethereum/common" - "github.com/google/uuid" - "github.com/stretchr/testify/assert" - "github.com/stretchr/testify/mock" - "github.com/stretchr/testify/require" - - feetypes "github.com/smartcontractkit/chainlink/v2/common/fee/types" - "github.com/smartcontractkit/chainlink/v2/common/txmgr" - txmgrtypes "github.com/smartcontractkit/chainlink/v2/common/txmgr/types" - commontxmmocks "github.com/smartcontractkit/chainlink/v2/common/txmgr/types/mocks" - "github.com/smartcontractkit/chainlink/v2/common/types" - "github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas" - evmtypes "github.com/smartcontractkit/chainlink/v2/core/chains/evm/types" - "github.com/smartcontractkit/chainlink/v2/core/internal/cltest" - "github.com/smartcontractkit/chainlink/v2/core/internal/testutils/configtest" - "github.com/smartcontractkit/chainlink/v2/core/internal/testutils/evmtest" - "github.com/smartcontractkit/chainlink/v2/core/internal/testutils/pgtest" - "github.com/smartcontractkit/chainlink/v2/core/services/chainlink" - "github.com/smartcontractkit/chainlink/v2/core/services/pg/datatypes" -) - -type TestingTxStore[ - ADDR types.Hashable, - CHAIN_ID types.ID, - TX_HASH types.Hashable, - BLOCK_HASH types.Hashable, - R txmgrtypes.ChainReceipt[TX_HASH, BLOCK_HASH], - SEQ types.Sequence, - FEE feetypes.Fee, -] interface { - CreateTransaction(ctx context.Context, txRequest txmgrtypes.TxRequest[ADDR, TX_HASH], chainID CHAIN_ID) (tx txmgrtypes.Tx[CHAIN_ID, ADDR, TX_HASH, BLOCK_HASH, SEQ, gas.EvmFee], err error) - Close() -} - -type txStoreFunc func(*testing.T, chainlink.GeneralConfig) (TestingTxStore[common.Address, *big.Int, common.Hash, common.Hash, *evmtypes.Receipt, evmtypes.Nonce, gas.EvmFee], common.Address, *big.Int) - -var txStoresFuncs = map[string]txStoreFunc{ - "evm_postgres_tx_store": evmTxStore, - "evm_in_memory_tx_store": inmemoryTxStore, -} - -func TestTxStore_CreateTransaction(t *testing.T) { - cfg := configtest.NewGeneralConfig(t, nil) - - for n, f := range txStoresFuncs { - t.Run(n, func(t *testing.T) { - txStore, fromAddress, chainID := f(t, cfg) - defer txStore.Close() - - subject := uuid.New() - strategy := commontxmmocks.NewTxStrategy(t) - strategy.On("Subject").Return(uuid.NullUUID{UUID: subject, Valid: true}) - strategy.On("PruneQueue", mock.Anything, mock.AnythingOfType("*txmgr.evmTxStore")).Return(int64(0), nil) - ctx := context.Background() - idempotencyKey := "11" - - tts := []struct { - scenario string - createTransactionInput createTransactionInput - createTransactionOutputCheck func(*testing.T, txmgrtypes.Tx[*big.Int, common.Address, common.Hash, common.Hash, evmtypes.Nonce, gas.EvmFee], error) - }{ - { - scenario: "success", - createTransactionInput: createTransactionInput{ - txRequest: txmgrtypes.TxRequest[common.Address, common.Hash]{ - IdempotencyKey: &idempotencyKey, - FromAddress: fromAddress, - ToAddress: common.BytesToAddress([]byte("test")), - EncodedPayload: []byte{1, 2, 3}, - FeeLimit: uint32(1000), - Meta: nil, - Strategy: strategy, - }, - chainID: chainID, - }, - createTransactionOutputCheck: func(t *testing.T, tx txmgrtypes.Tx[*big.Int, common.Address, common.Hash, common.Hash, evmtypes.Nonce, gas.EvmFee], err error) { - funcName := "CreateTransaction" - require.NoError(t, err, fmt.Sprintf("%s: expected err to be nil", funcName)) - assert.Equal(t, &idempotencyKey, tx.IdempotencyKey, fmt.Sprintf("%s: expected idempotencyKey to match actual idempotencyKey", funcName)) - // Check CreatedAt is within 1 second of now - assert.WithinDuration(t, time.Now().UTC(), tx.CreatedAt, time.Second, fmt.Sprintf("%s: expected time to be within 1 second of actual time", funcName)) - assert.Equal(t, txmgr.TxUnstarted, tx.State, fmt.Sprintf("%s: expected state to match actual state", funcName)) - assert.Equal(t, chainID, tx.ChainID, fmt.Sprintf("%s: expected chainID to match actual chainID", funcName)) - assert.Equal(t, fromAddress, tx.FromAddress, fmt.Sprintf("%s: expected fromAddress to match actual fromAddress", funcName)) - assert.Equal(t, common.BytesToAddress([]byte("test")), tx.ToAddress, fmt.Sprintf("%s: expected toAddress to match actual toAddress", funcName)) - assert.Equal(t, []byte{1, 2, 3}, tx.EncodedPayload, fmt.Sprintf("%s: expected encodedPayload to match actual encodedPayload", funcName)) - assert.Equal(t, uint32(1000), tx.FeeLimit, fmt.Sprintf("%s: expected feeLimit to match actual feeLimit", funcName)) - var expMeta *datatypes.JSON - assert.Equal(t, expMeta, tx.Meta, fmt.Sprintf("%s: expected meta to match actual meta", funcName)) - assert.Equal(t, uuid.NullUUID{UUID: subject, Valid: true}, tx.Subject, fmt.Sprintf("%s: expected subject to match actual subject", funcName)) - }, - }, - } - - for _, tt := range tts { - t.Run(tt.scenario, func(t *testing.T) { - actTx, actErr := txStore.CreateTransaction(ctx, tt.createTransactionInput.txRequest, tt.createTransactionInput.chainID) - tt.createTransactionOutputCheck(t, actTx, actErr) - }) - } - }) - } -} - -type createTransactionInput struct { - txRequest txmgrtypes.TxRequest[common.Address, common.Hash] - chainID *big.Int -} - -func evmTxStore(t *testing.T, cfg chainlink.GeneralConfig) (TestingTxStore[common.Address, *big.Int, common.Hash, common.Hash, *evmtypes.Receipt, evmtypes.Nonce, gas.EvmFee], common.Address, *big.Int) { - db := pgtest.NewSqlxDB(t) - keyStore := cltest.NewKeyStore(t, db, cfg.Database()) - _, fromAddress := cltest.MustInsertRandomKey(t, keyStore.Eth()) - ethClient := evmtest.NewEthClientMockWithDefaultChain(t) - chainID := ethClient.ConfiguredChainID() - - return cltest.NewTestTxStore(t, db, cfg.Database()), fromAddress, chainID -} -func inmemoryTxStore(t *testing.T, cfg chainlink.GeneralConfig) (TestingTxStore[common.Address, *big.Int, common.Hash, common.Hash, *evmtypes.Receipt, evmtypes.Nonce, gas.EvmFee], common.Address, *big.Int) { - db := pgtest.NewSqlxDB(t) - txStore := cltest.NewTestTxStore(t, db, cfg.Database()) - keyStore := cltest.NewKeyStore(t, db, cfg.Database()) - _, fromAddress := cltest.MustInsertRandomKey(t, keyStore.Eth()) - ethClient := evmtest.NewEthClientMockWithDefaultChain(t) - chainID := ethClient.ConfiguredChainID() - - ims, err := txmgr.NewInMemoryStore[ - *big.Int, common.Address, common.Hash, common.Hash, *evmtypes.Receipt, evmtypes.Nonce, gas.EvmFee, - ](chainID, keyStore.Eth(), txStore) - require.NoError(t, err) - - return ims, fromAddress, chainID -}