diff --git a/contracts/src/mcms.cairo b/contracts/src/mcms.cairo index c5c63d2b4..3b0b489bc 100644 --- a/contracts/src/mcms.cairo +++ b/contracts/src/mcms.cairo @@ -52,8 +52,6 @@ struct RootMetadata { override_previous_root: bool } -// todo: maybe use copy -// todo: figure out how this works off-chain with MCMS since we have a new selector field here #[derive(Copy, Drop, Serde)] struct Op { chain_id: u256, @@ -144,7 +142,6 @@ const MANY_CHAIN_MULTI_SIG_DOMAIN_SEPARATOR_OP: u256 = const MANY_CHAIN_MULTI_SIG_DOMAIN_SEPARATOR_METADATA: u256 = 0xe6b82be989101b4eb519770114b997b97b3c8707515286748a871717f0e4ea1c; -// todo: make sure this is the right way to encode the struct fn hash_metadata(metadata: RootMetadata, valid_until: u32) -> u256 { let encoded_metadata: Bytes = BytesTrait::new_empty() .encode(MANY_CHAIN_MULTI_SIG_DOMAIN_SEPARATOR_METADATA) diff --git a/contracts/src/tests/test_mcms/test_set_root.cairo b/contracts/src/tests/test_mcms/test_set_root.cairo index e22058412..dc1b66a49 100644 --- a/contracts/src/tests/test_mcms/test_set_root.cairo +++ b/contracts/src/tests/test_mcms/test_set_root.cairo @@ -735,12 +735,6 @@ fn test_wrong_pre_op_count() { } } } -// todo: make signer metadata a constant so you don't need to repeat yourself - -// todo: do two executes in between and then set the wrong root - -// pre - 2 -// post - 1 #[test] #[feature("safe_dispatcher")]