Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested Modification to Remappings in README.md #30

Open
jackie-cn opened this issue Jul 2, 2024 · 2 comments
Open

Suggested Modification to Remappings in README.md #30

jackie-cn opened this issue Jul 2, 2024 · 2 comments

Comments

@jackie-cn
Copy link

I propose a modification to the remappings example provided in the README.md file to enhance compatibility with the official usage examples provided by Chainlink. The current remapping configuration is as follows:

remappings = [
  '@chainlink/contracts/=lib/chainlink-brownie-contracts/contracts/src/',
]

However, based on the example usage documented on Chainlink's official documentation page Using Data Feeds, imports include the src directory within the path, as seen here:

import {AggregatorV3Interface} from "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";

With the current remapping setup, the path to AggregatorV3Interface.sol incorrectly includes an additional src, resulting in a file-not-found error. To rectify this, I suggest updating the remappings in the README.md to remove the extra src segment:

remappings = [
  '@chainlink/contracts/=lib/chainlink-brownie-contracts/contracts/',
]

This adjustment will align the remappings with the paths used in official examples, ensuring correct file resolution and smoother integration for users following the documentation.

@VAIBHAV152001
Copy link

Thank you for best explanation . it works !!!

@DevinBeu
Copy link

This just worked for me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants