Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marge Bot is logging PAT while fetching the repository #357

Open
Sayrus opened this issue Nov 3, 2022 · 0 comments
Open

Marge Bot is logging PAT while fetching the repository #357

Sayrus opened this issue Nov 3, 2022 · 0 comments

Comments

@Sayrus
Copy link

Sayrus commented Nov 3, 2022 •
edited
Loading

While investigating #356, I've stumbled upon logs from marge-bot:

2022-11-03 15:34:03,871 WARNING stderr: b"Cloning into '/tmpmpkpi0fl/tmpcefl0htl'...\nfatal: unable to access 'https://oauth2:[email protected]/repo.git/': SSL certificate problem: certificate has expired\n"

While the log is coming from the Git subprocess, the raw is forwarded to stderr due to how the subprocess pipes are configured. Is this the intended behavior?

This also happens on success as INFO logs pushed directly by marge-bot:

2022-11-10 14:53:17,436 INFO Running git clone --origin=origin https://oauth2:[email protected]/repo.git  /tmpnbm4i1nu/tmptcybhz__
@Sayrus Sayrus changed the title Marge Bot is logging PAT when an error occurs while fetching the repository Marge Bot is logging PAT while fetching the repository Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sayrus