Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question and thought #933

Closed
magicprinc opened this issue Nov 26, 2023 · 8 comments
Closed

Question and thought #933

magicprinc opened this issue Nov 26, 2023 · 8 comments

Comments

@magicprinc
Copy link
Contributor

magicprinc commented Nov 26, 2023

  1. I am really sorry 🙏, but I can't put snapshot build into the production.
    Could you please make a release with all those changes since 6.2.6?

  2. Please see Netty
    io.netty.util.concurrent.AbstractScheduledEventExecutor#defaultCurrentTimeNanos
    they use the same technic I have described in "timer memory optimization"

    /**
     * Get the current time in nanoseconds by this executor's clock. This is not the same as {@link System#nanoTime()}
     * for two reasons:
     *
     * <ul>
     *     <li>We apply a fixed offset to the {@link System#nanoTime() nanoTime}</li>
     *     <li>Implementations (in particular EmbeddedEventLoop) may use their own time source so they can control time
     *     for testing purposes.</li>
     * </ul>
     */
    protected long getCurrentTimeNanos() {
        return defaultCurrentTimeNanos();
    }

static long defaultCurrentTimeNanos() {
        return System.nanoTime() - START_TIME;
    }

After it, you have positive, small, ever-increasing nanoTime :-)
You can compare them with < and > without obscure subtraction technic.

@magicprinc
Copy link
Contributor Author

BTW: My PR vert-x3/vertx-awesome#189 to add SmallRye Fault Tolerance to Vert.x Awesome collection

@magicprinc
Copy link
Contributor Author

SmallRye Fault Tolerance is on the front page https://github.com/vert-x3/vertx-awesome !

It is time to publish a release (or at least a release candidate) 😅🙏🥂

@Ladicek
Copy link
Contributor

Ladicek commented Dec 4, 2023

Hi, I'm sorry I didn't have time to attend to this last week. I was busy with other things. I don't feel I'm ready to publish a final 6.3.0, but a release candidate sounds reasonable.

@Ladicek
Copy link
Contributor

Ladicek commented Dec 4, 2023

6.3.0-RC1 is on its way to Central, it typically doesn't take more than 15 minutes or so.

@magicprinc
Copy link
Contributor Author

magicprinc commented Feb 27, 2024

@Ladicek Any news about micrometer metrics in standalone mode and release version? 🙏

@Ladicek
Copy link
Contributor

Ladicek commented Feb 27, 2024

Not yet, unfortunately. The past few months, I've been busy with the upcoming CDI 4.1 release, but now that it's nearly done, I should have more time for other things. Fingers crossed :-)

@magicprinc
Copy link
Contributor Author

I see: you have developed standalone metrics support. 🔥
I am looking forward to RC :-) 🙏🚀

@Ladicek
Copy link
Contributor

Ladicek commented Mar 25, 2024

6.3.0-RC2 is on its way to Maven Central. Closing this issue, as all requests here have been addressed.

@Ladicek Ladicek closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants