Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mets:div/mets:fptr reference besides mets:structLink, or full ENMAP #65

Open
stefanCCS opened this issue Apr 29, 2022 · 2 comments

Comments

@stefanCCS
Copy link

It looks like, that the METS parser does not allow structures like this in METS:

                  <div ID="DIVL5" TYPE="TITLE_OF_WORK">
                     <fptr>
                        <area BETYPE="IDREF" FILEID="ALTO00001" BEGIN="P1_TB00002"/>
                     </fptr>

If I call mm2tei with this kind of METS I get an exception:

Traceback (most recent call last):
  File "/home/calamariadmin/tei_venv_3.7/bin/mm2tei", line 8, in <module>
    sys.exit(cli())
  File "/home/calamariadmin/tei_venv_3.7/lib/python3.7/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/calamariadmin/tei_venv_3.7/lib/python3.7/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/calamariadmin/tei_venv_3.7/lib/python3.7/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/calamariadmin/tei_venv_3.7/lib/python3.7/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/calamariadmin/tei_venv_3.7/lib/python3.7/site-packages/mets_mods2tei/scripts/mets_mods2tei.py", line 56, in cli
    tei.fill_from_mets(mets, ocr)
  File "/home/calamariadmin/tei_venv_3.7/lib/python3.7/site-packages/mets_mods2tei/api/tei.py", line 175, in fill_from_mets
    self.add_div_structure(div)
  File "/home/calamariadmin/tei_venv_3.7/lib/python3.7/site-packages/mets_mods2tei/api/tei.py", line 831, in add_div_structure
    div = div.get_div()[0]
IndexError: list index out of range

As a starting point an "ignore" of <fptr><area> in <div> area would be good.
In general it would be even better, if the OCR text from ALTO is taken from the link referenced there.

@bertsky
Copy link
Member

bertsky commented Apr 29, 2022

div = div.get_div()[0]
IndexError: list index out of range

That's actually #64 (which would entail the ignore strategy), but the additional issue here is indeed that mets:fptr/mets:area references instead of mere mets:structLink matches for the mets:div/@ID should be supported.

Maximally, support for the ENMAP profile is desired.

@bertsky
Copy link
Member

bertsky commented Apr 29, 2022

Further reference: ENMAP examples

@bertsky bertsky changed the title METS parser does not allow <fptr><area> - got Exception support mets:div/mets:fptr reference besides mets:structLink, or full ENMAP Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants