Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist all twiddle arrays to C level #109

Open
hanno-becker opened this issue Nov 25, 2024 · 0 comments
Open

Hoist all twiddle arrays to C level #109

hanno-becker opened this issue Nov 25, 2024 · 0 comments

Comments

@hanno-becker
Copy link
Collaborator

We currently jump through some hoops (https://github.com/pq-code-package/mlkem-native/blob/main/mlkem/native/aarch64/common.i) on the assembly level to be able to load the addresses of twiddle tables.

It should be easier to have the twiddle tables in C and just pass their address as an argument to the assembly. This way, we leave the address calculation to the compiler.

Having all twiddle tables in C also makes it easier to have common auto-generation code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant