Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests failing on qemu #5

Closed
mkannwischer opened this issue Jul 22, 2024 · 5 comments · Fixed by #12
Closed

Fix tests failing on qemu #5

mkannwischer opened this issue Jul 22, 2024 · 5 comments · Fixed by #12

Comments

@mkannwischer
Copy link
Contributor

#4 identified that 5 tests are currently non-functional on the qemu m55-an547 platform:

  • chunk
  • montgomery
  • ntt-1024
  • saber
  • schoolbook

They are currently commented out in the root Makefile and won't run in CI.

I don't have any bandwidth to debug those, and I have little interest to keep maintaining them.
They are all unrelated to SLOTHY and come from https://gitlab.com/arm-research/security/pqmx.
If someone wants to fix them, please go ahead. If not fixed by the end of the year, it's probably better to delete them here to not pollute the repo too much.

@hanno-becker
Copy link
Contributor

chunk fixed in #9

@hanno-becker
Copy link
Contributor

hanno-becker commented Jul 22, 2024

montgomery fixed in #9

@hanno-becker
Copy link
Contributor

Fixed Saber test in #11

@hanno-becker
Copy link
Contributor

Removed schoolbook test in #11

hanno-becker added a commit that referenced this issue Jul 23, 2024
@hanno-becker
Copy link
Contributor

ntt-1024 fixed in #12

hanno-becker added a commit that referenced this issue Jul 23, 2024
hanno-becker added a commit that referenced this issue Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants