Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Handle @image-url #6934

Merged
merged 3 commits into from
Nov 28, 2024
Merged

LSP: Handle @image-url #6934

merged 3 commits into from
Nov 28, 2024
+62 −8

Conversation

hunger
Copy link
Member

@hunger hunger commented Nov 27, 2024

Hovering will display the absolute file name and goto definition will open the file

szecket
szecket approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@szecket szecket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

ogoffart
ogoffart approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but it is missing a test.
Both goto.rs and hober.rs already have tests that can be modified to include a link to an image.

@hunger
Copy link
Member Author

hunger commented Nov 28, 2024

Yeah, the tests are indeed missing. I wanted to show what I had to @szecket :-)

@hunger
LSP: Handle @image-url
215a5aa 
Hovering will display the absolute file name and goto definition
will open the file
ogoffart
ogoffart approved these changes Nov 28, 2024
View reviewed changes
tools/lsp/language/goto.rs Outdated Show resolved Hide resolved
tools/lsp/language/hover.rs Show resolved Hide resolved
hunger and others added 2 commits November 28, 2024 10:50
@ogoffart
Copy link
Member

I wonder if the tooltip for a image-url could contain the actual image.
Instead of showing the URL as code, it could contain ![Image]({target_path}) or something like that. that might work. (doesn't need to be in this PR)

@hunger
Copy link
Member Author

hunger commented Nov 28, 2024

Oh, what a wonderful idea!

@hunger hunger merged commit de06c39 into slint-ui:master Nov 28, 2024
37 checks passed
@hunger hunger deleted the tobias/push-otzqpvmulsny branch November 28, 2024 10:44
@hunger hunger restored the tobias/push-otzqpvmulsny branch November 28, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szecket szecket szecket approved these changes

@ogoffart ogoffart ogoffart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hunger @ogoffart @szecket