Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

源码中没有定义IKCP_FASTACK_CONSERVE宏导致的重复快重传问题 #408

Open
Alan-yly opened this issue Apr 8, 2024 · 3 comments
Open

源码中没有定义IKCP_FASTACK_CONSERVE宏导致的重复快重传问题 #408

Alan-yly opened this issue Apr 8, 2024 · 3 comments

Comments

@Alan-yly
Copy link
Contributor

Alan-yly commented Apr 8, 2024

在ikcp_parse_fastack函数里发现如果不定义IKCP_FASTACK_CONSERVE宏，会导致已经重传的报文的报文被反复触发快重传，比如：发送端A报文已经重传了，之后发送端收到大于A报文编号的几个报文的ack，那么这些ack又会导致快重传A报文。
image
@skywind3000
Copy link
Owner

那你就定义呗。

@Alan-yly
Copy link
Contributor Author

Alan-yly commented Apr 9, 2024

我这里能不能提个pr？

@nlifew
Copy link

nlifew commented Jul 31, 2024

对应的 pr 已经合入，这个 issue 已经可以关闭了 @Alan-yly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skywind3000 @nlifew @Alan-yly