Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging>=23.1 - can it move to dev instead of install_required ? #898

Open
zbenmo opened this issue Apr 1, 2024 · 2 comments
Open

packaging>=23.1 - can it move to dev instead of install_required ? #898

zbenmo opened this issue Apr 1, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@zbenmo
Copy link

zbenmo commented Apr 1, 2024

Problem Description

If the following can move from install_required to dev or so, I would be happy:

packaging>=23.1

Tried to use skrub on Kaggle, no Internet. brought into the environment the 0.1.0 wheel. Yet above causes issues.

Feature Description

If the following can move from install_required to dev or so, I would be happy:

packaging>=23.1

Tried to use skrub on Kaggle, no Internet. brought into the environment the 0.1.0 wheel. Yet above causes issues.

Alternative Solutions

Move it to dev?

Additional Context

No response

@zbenmo zbenmo added the enhancement New feature or request label Apr 1, 2024
@jeromedockes
Copy link
Member

thanks for reporting.
dependencies are checked when importing the package (not just when installing it), and the machinery that does that uses packaging. This was added in #365
maybe @GaelVaroquaux or @Vincent-Maladiere have more insights on the pros and cons of having this check?

in any case I'm not sure why packaging would be more problematic than the other dependencies; could you provide a description of your environment (eg conda list) and the exact error message? thanks!

@zbenmo
Copy link
Author

zbenmo commented Apr 22, 2024

Without internet, the Kaggle environment could not find 'packaging>=23.1', probably it has something earlier. I removed that dependency (commented out 'packaging>=23.1') in my cloned copy of 'skrub' on my laptop, rebuilt the 'skrub' package, and used that wheel (uploaded it to Kaggle to where it can access it also when no Internet). It worked for me on the same Kaggle environment from above (also when no Internet connection).

What if this or another dependency/package are really needed? I should bring their wheel also. But anything that is not a must would be better used only when needed. I assume 'packaging' is more related to build/dev time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants