Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableReport Stats doesn't display nunique Integers #1070

Closed
Vincent-Maladiere opened this issue Sep 12, 2024 · 1 comment · Fixed by #1154
Closed

TableReport Stats doesn't display nunique Integers #1070

Vincent-Maladiere opened this issue Sep 12, 2024 · 1 comment · Fixed by #1154
Labels
enhancement New feature or request
Milestone
0.3.2

Comments

@Vincent-Maladiere
Copy link
Member

Describe the bug

Linked to #1052

Integer values should have a cardinality displayed in "Stats". Integers can represent IDs or other discrete quantities.

Steps/Code to Reproduce

NA

Expected Results

NA

Actual Results

NA

Versions

NA
@Vincent-Maladiere Vincent-Maladiere added the bug Something isn't working label Sep 12, 2024
@jeromedockes jeromedockes added enhancement New feature or request and removed bug Something isn't working labels Sep 12, 2024
@jeromedockes
Copy link
Member

yes ATM it does not check cardinality for numeric columns. we could do it for integers and replace the histogram with a bar plot when the cardinality is low

@jeromedockes jeromedockes added this to the 0.3.2 milestone Nov 18, 2024
@jeromedockes jeromedockes mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.2
Development

Successfully merging a pull request may close this issue.

compute n_unique for all columns in tablereport jeromedockes/skrub
2 participants
@jeromedockes @Vincent-Maladiere