Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw on unknown action breaks react-devtools #163

Open
yesmeck opened this issue Nov 27, 2020 · 2 comments
Open

throw on unknown action breaks react-devtools #163

yesmeck opened this issue Nov 27, 2020 · 2 comments
Labels

Comments

@yesmeck
Copy link

yesmeck commented Nov 27, 2020

Since react-devtools will also use postMessage to communicate with webview, so throw on unknown action breaks the react-devtools.

' if (!actionName) {' +
" throw new Error('missing action name')" +
' }' +

@yesmeck
Copy link
Author

yesmeck commented Dec 14, 2020

@mathieudutour Why wontfix? I don't see actionName was used anywhere.

@mathieudutour
Copy link
Member

It won't matter whether we throw or not because we completely replace the postMessage method. So the issue would be to design another mechanism to communicate with the webview - and we won't do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants