Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0 #232

Open
doberkofler opened this issue Sep 18, 2024 · 7 comments

Comments

@doberkofler
Copy link

Your issue may already be reported!
Please search on the issue tracker before creating one.

Expected Behavior

After upgrading to sass 1.79.1, i see the following warning:
Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

Your Environment

  • Version used: 8.0.1
  • Operating System and versions: macOS 15.0
@doberkofler
Copy link
Author

@terrymun
Copy link

It seems like the deprecation notice is coming from the consumption of LegacySyncImporter and LegacySyncImporterThis in two instances in the source code: in importer.ts and in importer.test.ts.

Perhaps a migration isn't as painful as it seems? (famous last words)

@am0wa
Copy link

am0wa commented Oct 31, 2024

At least provide a passthrough option to silence it out, Please.

@cryptofelon
Copy link

At least provide a passthrough option to silence it out, Please.

PLEASE.

@vilindberg
Copy link

vilindberg commented Dec 12, 2024

I created a patch that uses the new apis instead: https://gist.github.com/vilindberg/f620f5453c74aa856762dcc8ce0a6435

This worked well and solved the issue for us. Hopefully it works for some of you as well.

@skovy
Copy link
Owner

skovy commented Dec 21, 2024

this is an open source project, changes can be opened as pull requests! i don't use this project, nor get paid to maintain it so there will be lag to reviewing and merging. if in a pinch forking and patching are also options!

@crgwbr
Copy link

crgwbr commented Dec 23, 2024

this is an open source project, changes can be opened as pull requests! i don't use this project, nor get paid to maintain it so there will be lag to reviewing and merging. if in a pinch forking and patching are also options!

@skovy If you're interested moving this project to a new maintainer, my team at the @thelabnyc might be interested. We do use this tool on quite a few projects, so we'd have a basis to justify the investment. Feel free to email me to discuss more: cweber at thelab dot co.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants