Fix CVE-2017-16100: Abandon validation using an unsafe regex pattern in favor of tokenizing and applying a linear pattern #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in favor of tokenizing and applying a linear pattern
|
I am not sure if this package is abandoned or not. Assuming the worst, I have published the fix in a package on npm: https://www.npmjs.com/package/@amoo-miki/dns-sync |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change abandons the use of an unsafe regex pattern for validating hostnames in favor of tokenizing and applying a linear pattern.
Fixes #5
#9 was not a suitable fix as it introduced a binary dep that complicated its adoption for us and perhaps many others.