From 40c1102a4e86c7a9a52ebde9667b1788590c916b Mon Sep 17 00:00:00 2001
From: Ron Hudson <3606628+pastorhudson@users.noreply.github.com>
Date: Wed, 24 Mar 2021 08:13:44 -0400
Subject: [PATCH] Travis Fix, Github Actions, heroku fix (#432)

* Travis Fix, Github Actions, heroku fix
- Fix travis-ci
- Add github actions ci
- Remove 2.7, 3.5 from ci
- Add 3.6, 3.7, 3.8, 3.9 to ci
- Various requirements changes to support current python & fix tests
- Fix flake8 errors
- Bumped Heroku to python-3.9.2. I tested heroku with 3.6, 3.7, 3.8, 3.9 all with the new slack_update and it worked.

Travis is migrating away from travis-ci.org to travis-ci.com and changing how the free tier works. I would support moving away from travis and embracing github actions. But it doesn't hurt anything to run both for now.

* Removed duplicate comment

* Removed redundant pip installs

* - Pin natural to github version
- exclude flake8 for natural

* Pin natural to github commit
---
 .github/workflows/python-app.yml    | 26 ++++++++++++++++++++++++++
 .travis.yml                         |  5 ++---
 runtime.txt                         |  2 +-
 setup.py                            |  2 +-
 tox.ini                             | 11 +++++++++--
 will/plugins/productivity/remind.py |  1 -
 will/requirements/base.txt          | 16 +++++++++-------
 will/requirements/dev.txt           |  2 +-
 will/tests/test_plugin.py           |  2 ++
 9 files changed, 51 insertions(+), 16 deletions(-)
 create mode 100644 .github/workflows/python-app.yml
 mode change 100755 => 100644 setup.py

diff --git a/.github/workflows/python-app.yml b/.github/workflows/python-app.yml
new file mode 100644
index 00000000..25532ab8
--- /dev/null
+++ b/.github/workflows/python-app.yml
@@ -0,0 +1,26 @@
+name: Python package
+
+on:
+  - push
+  - pull_request
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [3.6, 3.7, 3.8, 3.9]
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install -r will/requirements/dev.txt
+        pip install tox-gh-actions
+    - name: Test with tox
+      run: tox
\ No newline at end of file
diff --git a/.travis.yml b/.travis.yml
index 5694b3b2..02a3be66 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,11 +1,10 @@
 dist: xenial
 language: python
 python:
-  - '2.7'
-  - '3.4'
-  - '3.5'
   - '3.6'
   - '3.7'
+  - '3.8'
+  - '3.9'
 sudo: false
 services:
   - docker
diff --git a/runtime.txt b/runtime.txt
index d56a3d02..9a604613 100644
--- a/runtime.txt
+++ b/runtime.txt
@@ -1 +1 @@
-python-2.7.3
\ No newline at end of file
+python-3.9.2
\ No newline at end of file
diff --git a/setup.py b/setup.py
old mode 100755
new mode 100644
index 6cdb833c..6b4af517
--- a/setup.py
+++ b/setup.py
@@ -37,7 +37,7 @@
 
 tests_require = [
     'mock',
-    'pytest==4.6.6',
+    'pytest==6.2.2',
     'pytest-cov',
     'pytest-runner',
     'pytest-mock',
diff --git a/tox.ini b/tox.ini
index 582d6121..a50fb8a6 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,6 +1,13 @@
 [tox]
-envlist = py27, py34, py35, py36, py37
+envlist = py36, py37, py38, py39
 
+[gh-actions]
+python =
+    2.7: py27
+    3.6: py36
+    3.7: py37
+    3.8: py38, mypy
+    3.9: py39
 
 [testenv]
 deps =
@@ -9,4 +16,4 @@ deps =
     -rrequirements.txt
 commands = 
     python setup.py test
-    flake8
+    flake8 --extend-exclude=./src/natural/*
diff --git a/will/plugins/productivity/remind.py b/will/plugins/productivity/remind.py
index c43f92c0..b5085450 100644
--- a/will/plugins/productivity/remind.py
+++ b/will/plugins/productivity/remind.py
@@ -15,7 +15,6 @@ def remind_me_at(self, message, reminder_text=None, remind_time=None, to_string=
             formatted_to_string = ""
         formatted_reminder_text = "%(mention_handle)s, you asked me to remind you%(to_string)s %(reminder_text)s" % {
             "mention_handle": message.sender.mention_handle,
-            "from_handle": message.sender.handle,
             "reminder_text": reminder_text,
             "to_string": formatted_to_string,
         }
diff --git a/will/requirements/base.txt b/will/requirements/base.txt
index 60754139..50b9fbbf 100644
--- a/will/requirements/base.txt
+++ b/will/requirements/base.txt
@@ -1,27 +1,29 @@
 APScheduler==2.1.2
 beautifulsoup4==4.6.0
-bottle==0.12.7
-CherryPy==3.6.0
+bottle==0.12.19
+CherryPy==8.9.1
 clint==0.5.1
 dill==0.3.3
 dnspython==1.15.0
 fuzzywuzzy==0.15.1
 Jinja2==2.7.3
-Markdown==2.3.1
+Markdown==3.3.4
 MarkupSafe==0.23
+# Pin natural to repo since release is not updated
+-egit+git://github.com/tehmaze/natural.git@4d41ed6708965420ad884339e0e9ca5f089b2202#egg=natural
 # Temporary fork of natural, until python 3 support is merged: https://github.com/tehmaze/natural/pull/13
-# natural==0.2.1
-will-natural==0.2.1.1
+# will-natural==0.2.1.1
 parsedatetime==1.1.2
 python-Levenshtein==0.12.1
 pyasn1-modules==0.0.5
 pyasn1==0.1.7
 pycrypto==2.6.1
 pygerduty==0.28
-pytz==2017.2
-PyYAML==3.13
+pytz==2021.1
+PyYAML==5.4.1
 regex==2017.9.23
 redis==2.10.6
 requests==2.25.0
 six==1.15.0
 urllib3==1.25.10
+websocket-client==0.44.0
diff --git a/will/requirements/dev.txt b/will/requirements/dev.txt
index 2cae7f8a..68a2b4cd 100644
--- a/will/requirements/dev.txt
+++ b/will/requirements/dev.txt
@@ -10,7 +10,7 @@ nose
 coverage
 yappi
 tox
-pytest==4.6.6
+pytest==6.2.2
 pytest-cov
 pytest-mock
 freezegun
diff --git a/will/tests/test_plugin.py b/will/tests/test_plugin.py
index c5232efa..8f7cef1a 100644
--- a/will/tests/test_plugin.py
+++ b/will/tests/test_plugin.py
@@ -135,6 +135,8 @@ def test_get_backend_service_as_parameter(message, plugin, io_backend, all_io_ba
 # freeze_time to mock datetime.datetime.now() method which is invoked
 # when creating an event or message.
 # https://github.com/spulec/freezegun
+
+
 @freeze_time(WILLS_BIRTHDAY)
 def test_say_with_room_arg(plugin, content, say_event, source_message, outgoing_topic):
     room = "test"