You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Redundant Variable:
Lines: 83,88
Class: TextPresenterTest
Info:
Runnable is an interface
Our Conclusion:
Not needed, and can be deleted
Lines: 72,73
Class: Gride
Info:
You make a grid to then just return it
Our Conclusion:
You can just inline this function
Simplify if statement:
Line : 89
Class: TestPresenter
Info:
There is an if statement that is answer == true you need to just make the if statement
if(answer)
Simplify Testing Code:
Line: 53
Class: CooedTest
Info:
You have an assertEquales that really need to be an assertTrue
Lines: 52,62
Class: GrideTest
Info:
These are assertEquals that need to be assertFalse
Line:76
Class: GrideTest
Info:
This is assertEquals that needs to be assert True
Make final
Class: GridTest
Line: 9
Info:
Make the object final
Our concussion:
Change it
Class: Grid
Line: 15
Info:
Make the shipList field final
Confusion:
You do not want to change the list of ships after you make it, but we decide to make
it into where you can restart the game with a new grid size you want to change this
back to not final
Class: ship
Line: 13
Info:
Make the startcoordinate field final
Confusion:
You want this be to final because they will start at the same spot every time
Class: ShipTest
Lines: 9,10,11
Info:
Make fields coordinate,ship,grid
Concussion:
Once they are declared they are not changed
Class: TextPresenter
Lines: 14,15,16
Info:
Make the fields output,input,scanner final
Concussion:
You would have no reason to change these after you have started the game because
it will change where you see the output is at.
The text was updated successfully, but these errors were encountered:
Redundant Variable:
Lines: 83,88
Class: TextPresenterTest
Info:
Runnable is an interface
Our Conclusion:
Not needed, and can be deleted
Lines: 72,73
Class: Gride
Info:
You make a grid to then just return it
Our Conclusion:
You can just inline this function
Simplify if statement:
Line : 89
Class: TestPresenter
Info:
There is an if statement that is answer == true you need to just make the if statement
if(answer)
Simplify Testing Code:
Line: 53
Class: CooedTest
Info:
You have an assertEquales that really need to be an assertTrue
Lines: 52,62
Class: GrideTest
Info:
These are assertEquals that need to be assertFalse
Line:76
Class: GrideTest
Info:
This is assertEquals that needs to be assert True
Make final
Class: GridTest
Line: 9
Info:
Make the object final
Our concussion:
Change it
Class: Grid
Line: 15
Info:
Make the shipList field final
Confusion:
You do not want to change the list of ships after you make it, but we decide to make
it into where you can restart the game with a new grid size you want to change this
back to not final
Class: ship
Line: 13
Info:
Make the startcoordinate field final
Confusion:
You want this be to final because they will start at the same spot every time
Class: ShipTest
Lines: 9,10,11
Info:
Make fields coordinate,ship,grid
Concussion:
Once they are declared they are not changed
Class: TextPresenter
Lines: 14,15,16
Info:
Make the fields output,input,scanner final
Concussion:
You would have no reason to change these after you have started the game because
it will change where you see the output is at.
The text was updated successfully, but these errors were encountered: