Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in fast consensus patch enabling #1932

Closed
kladkogex opened this issue Jul 2, 2024 · 0 comments · Fixed by #1933
Closed

Bug in fast consensus patch enabling #1932

kladkogex opened this issue Jul 2, 2024 · 0 comments · Fixed by #1933
Assignees
@kladkogex
Labels
bug Something isn't working
Milestone
SKALE 2.4

Comments

@kladkogex
Copy link
Collaborator

We have a potential bug in enabling fast consensus patch.

It needs to take the timestamp for the blockid previous to the in consensus.

It currently takes the last block timestamp. but does not take into account the fact that last block may concurrently change since a new block may come from catchup

It is better to specifically take the timestamp of blockid in consensus minus one.
@kladkogex kladkogex linked a pull request Jul 2, 2024 that will close this issue
1932_better_consensus_patch_timestamp #1933
Merged
@DmytroNazarenko DmytroNazarenko added this to the SKALE 2.4 milestone Jul 9, 2024
@DmytroNazarenko DmytroNazarenko added the bug Something isn't working label Jul 9, 2024
@DmytroNazarenko DmytroNazarenko moved this to Ready For Release Candidate in SKALE Engineering 🚀 Jul 9, 2024
@PolinaKiporenko PolinaKiporenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kladkogex kladkogex

Labels
bug Something isn't working
Projects
SKALE Engineering 🚀
Archived in project
Milestone
SKALE 2.4
Development

Successfully merging a pull request may close this issue.

1932_better_consensus_patch_timestamp skalenetwork/skaled
2 participants
@kladkogex @DmytroNazarenko