Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ABI right after smart contract upgrade #51

Closed
DimaStebaev opened this issue Mar 18, 2024 · 0 comments · Fixed by #65, #66 or skalenetwork/skale-manager#1095
Closed

Missing ABI right after smart contract upgrade #51

DimaStebaev opened this issue Mar 18, 2024 · 0 comments · Fixed by #65, #66 or skalenetwork/skale-manager#1095
Assignees
@DimaStebaev
Labels
Techical debt
Milestone
SKALE 3.1

Comments

@DimaStebaev
Copy link
Contributor

Describe the bug
There is a delay between github release creation and smart contracts upgrade. During this period skale-contracts can't download needed ABI because they does not exist.

Proposed solution
To use ABI from release-candidate version if stable version is missing on github.
@DimaStebaev DimaStebaev self-assigned this Mar 18, 2024
@DmytroNazarenko DmytroNazarenko added this to the SKALE 2.4 milestone Mar 18, 2024
@DmytroNazarenko DmytroNazarenko moved this to Ready For Pickup in SKALE Engineering 🚀 Mar 18, 2024
@PolinaKiporenko PolinaKiporenko modified the milestones: SKALE 2.4, SKALE 2.5 Apr 9, 2024
@DimaStebaev DimaStebaev linked a pull request Jul 12, 2024 that will close this issue
Download ABI from release condidate branch if stable is missing #65
Merged
@DimaStebaev DimaStebaev moved this from Ready For Pickup to In Progress in SKALE Engineering 🚀 Jul 12, 2024
@DimaStebaev DimaStebaev moved this from In Progress to Code Review in SKALE Engineering 🚀 Jul 16, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Jul 18, 2024
This was linked to pull requests Jul 18, 2024
Release 1.0.1 #66
Merged
Add rc branch skalenetwork/skale-manager#1095
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimaStebaev DimaStebaev

Labels
Techical debt
Projects
SKALE Engineering 🚀
Status: Ready For Release Candidate
Milestone
SKALE 3.1
3 participants
@DimaStebaev @DmytroNazarenko @PolinaKiporenko