Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skaled should be started by skaleadmin first #942

Closed
kladkogex opened this issue Apr 25, 2023 · 4 comments · Fixed by skalenetwork/predeployed-generator#84, skalenetwork/marionette#380, skalenetwork/marionette#381, skalenetwork/etherbase#337 or skalenetwork/etherbase#338
Closed

Skaled should be started by skaleadmin first #942

kladkogex opened this issue Apr 25, 2023 · 4 comments · Fixed by skalenetwork/predeployed-generator#84, skalenetwork/marionette#380, skalenetwork/marionette#381, skalenetwork/etherbase#337 or skalenetwork/etherbase#338
Assignees
@badrogger
Labels
enhancement New feature or request epic:node-rotation release:2.2
Milestone
2.2

Comments

@kladkogex
Copy link
Contributor

Describe the bug

Currently there are cases where failed DKG can prevent skaled from start.

Expected behavior

Skaled needs to run nomatter what happens to to DKG

One way to to do it is to handle skaled first when skaledadmin starts.

Cleaner way is to have a separate skaled restart agent (may be systemd or similar)
and have skale-admin talk to this agent
@kladkogex kladkogex added the bug Something isn't working label Apr 25, 2023
@kladkogex kladkogex added this to the 2.2 milestone Apr 25, 2023
@DmytroNazarenko
Copy link
Contributor

Scope 2.2 for this ticket:

  • Extract config generation into separate process that will run DKG + config generation
  • Skaled process will change firewall rules, validate config, restart skaled, skaled healthchecks

@DmytroNazarenko DmytroNazarenko moved this to Ready For Pickup in SKALE Engineering 🚀 May 2, 2023
@DmytroNazarenko DmytroNazarenko added enhancement New feature or request and removed bug Something isn't working labels May 2, 2023
@DmytroNazarenko DmytroNazarenko moved this from Ready For Pickup to To Do in SKALE Engineering 🚀 May 4, 2023
@DmytroNazarenko DmytroNazarenko moved this from To Do to Ready For Pickup in SKALE Engineering 🚀 May 5, 2023
@badrogger badrogger moved this from Ready For Pickup to Blocked in SKALE Engineering 🚀 May 22, 2023
@badrogger badrogger moved this from Blocked to In Progress in SKALE Engineering 🚀 May 22, 2023
@DmytroNazarenko DmytroNazarenko linked a pull request Jun 13, 2023 that will close this issue
Add calculate_keccak function skalenetwork/predeployed-generator#84
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Ready For Release Candidate in SKALE Engineering 🚀 Jun 13, 2023
@DmytroNazarenko DmytroNazarenko linked a pull request Jun 13, 2023 that will close this issue
Update setup.cfg skalenetwork/marionette#380
Merged
This was referenced Jun 13, 2023
Open
Merged
@DmytroNazarenko DmytroNazarenko linked a pull request Jun 13, 2023 that will close this issue
Develop to beta skalenetwork/marionette#381
Merged
This was referenced Jun 13, 2023
Open
Merged
Merged
@DmytroNazarenko DmytroNazarenko linked a pull request Jun 13, 2023 that will close this issue
Develop to beta skalenetwork/etherbase#338
Merged
@badrogger badrogger moved this from Ready For Release Candidate to Code Review in SKALE Engineering 🚀 Jun 19, 2023
@badrogger badrogger linked a pull request Jun 19, 2023 that will close this issue
Split monitor process for config and skaled #945
Merged
@DmytroNazarenko DmytroNazarenko linked a pull request Jun 20, 2023 that will close this issue
v2.5.x #949
Merged
@DmytroNazarenko DmytroNazarenko moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Jun 20, 2023
@DmytroNazarenko DmytroNazarenko linked a pull request Jun 20, 2023 that will close this issue
Develop to beta #950
Merged
@DmytroNazarenko DmytroNazarenko mentioned this issue Jun 20, 2023
Merged
@DmytroNazarenko
Copy link
Contributor

skale-manager: 1.9.4-beta.0
skale-admin: 2.5.0-beta.1

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jun 21, 2023
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jun 21, 2023
@yatsunastya
Copy link

Blocked by https://github.com/skalenetwork/internal-support/issues/851

@yatsunastya
Copy link

yatsunastya commented Aug 15, 2023 •
edited
Loading

Checked ✅
admin: 2.5.1-develop.2

  • upstrem config is successfully created after each node rotation (no matter what happens with DKG)
  • After removing skaled container during DKG, admin recreated it and skaled successfully started mining blocks

@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Oct 12, 2023
@DmytroNazarenko DmytroNazarenko linked a pull request Oct 23, 2023 that will close this issue
Add --pull--config option to skale node update skalenetwork/node-cli#734
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@badrogger badrogger

Labels
enhancement New feature or request epic:node-rotation release:2.2
Projects
SKALE Engineering 🚀
Archived in project
Milestone
2.2
4 participants
@badrogger @kladkogex @DmytroNazarenko @yatsunastya