Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set reload_ts in case of node rotation #1042

Open
yatsunastya opened this issue Jan 30, 2024 · 0 comments
Open

Don't set reload_ts in case of node rotation #1042

yatsunastya opened this issue Jan 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@yatsunastya
Copy link

Describe the bug
In case of node rotation, reload_ts is set to None (Setting reload_ts to None) because new node comes to the group (and new node IP "change IP"). It's necessary to compare rotation ID in skaled and upstream configs, and if they are different (which means node rotation is in progress), just don't set reload_ts.

To Reproduce
Steps to reproduce the behavior:

  1. Start node rotation procedure
  2. Go skale_admin logs
  3. See Setting reload_ts to None for the rotating schain

Expected behavior
reload_ts is set only in case of change IP procedure.

@yatsunastya yatsunastya added the bug Something isn't working label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants