Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set gasprice during getRecommendedRechargeAmount #282

Closed
yavrsky opened this issue Sep 24, 2024 · 2 comments · Fixed by #283 or skalenetwork/portal#409
Closed

Set gasprice during getRecommendedRechargeAmount #282

yavrsky opened this issue Sep 24, 2024 · 2 comments · Fixed by #283 or skalenetwork/portal#409
Assignees
@dmytrotkk
Labels
enhancement New feature or request
Milestone
IMA Gas Wallet

Comments

@yavrsky
Copy link

yavrsky commented Sep 24, 2024

In the IMA 2.3.0 we removed block.basefee from method getRecommendedRechargeAmount. It appears that block.basefee always returns 0 during eth_calls, so tx.gasprice was added instead. Now for getRecommendedRechargeAmount you need set gasprice to get reasonable value.
@DmytroNazarenko DmytroNazarenko added the enhancement New feature or request label Oct 7, 2024
@DmytroNazarenko DmytroNazarenko added this to the IMA Gas Wallet milestone Oct 7, 2024
@PolinaKiporenko PolinaKiporenko moved this from Ready For Pickup to To Do in SKALE Engineering 🚀 Oct 10, 2024
@dmytrotkk dmytrotkk linked a pull request Oct 29, 2024 that will close this issue
Update community pool logic, remove legacy components #283
Merged
@github-project-automation github-project-automation bot moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Oct 30, 2024
@dmytrotkk dmytrotkk linked a pull request Oct 30, 2024 that will close this issue
Update package.json skalenetwork/portal#409
Merged
@yatsunastya
Copy link

Checked ✅
Version: 3.1.0-beta.2

Recharge Exit Gas wallet transaction

Знімок екрана 2024-11-04 о 15 24 57

@EvgeniyZZ
Copy link

Additionally, this call required gasPric, as result this call will not work in block explorer, etherscan without additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmytrotkk dmytrotkk

Labels
enhancement New feature or request
Projects
SKALE Engineering 🚀
Status: Done
Milestone
IMA Gas Wallet
5 participants
@dmytrotkk @DmytroNazarenko @yavrsky @EvgeniyZZ @yatsunastya