2.0.2 Hotifx Beta #232
Merged
2.0.2 Hotifx Beta #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix chainId in enforce network
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hotfix: add Nebula faucet
Add sendTx func, add more exports
Update send tx function
Update enforce netork function signature
TheGreatAxios
approved these changes
Jan 4, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@skalenetwork/metaport", | |||
| "version": "2.0.1", | |||
| "version": "2.0.3", | |||
There was a problem hiding this comment.
Note -> Skipped 2.0.2
| walletClient: WalletClient, | ||
| switchNetwork: (chainId: number | bigint) => Promise<Chain | undefined>, | ||
| chainId: bigint, | ||
| walletClient: any, |
There was a problem hiding this comment.
Usage of cast to WalletClient to create local instance _walletClient on line 156 starts here.
Ideal Cleanup
- Type any-> WalletClient
- Remove use of _walletClient unless it specifically uses a local scoped version?
| await response.wait() | ||
| return { status: true, err: undefined, response: response } | ||
| } catch (err) { | ||
| console.error(err) |
There was a problem hiding this comment.
Ideally should not print errors in production unless via different debug channel.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta version for 2.0.2 release.