Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure metaport config, drop dynamic token lookup, replace persistent Metamask connection #168

Closed
dmytrotkk opened this issue May 29, 2023 · 2 comments · Fixed by #184
Assignees
Labels
enhancement New feature or request

Comments

@dmytrotkk
Copy link
Contributor

dmytrotkk commented May 29, 2023

The current Metaport config structure doesn't allow us to add complex routes (e.g. Mainnet -> Europa -> Calypso)

Changes that should be made:

  1. Drop dynamic token lookup, and list all token mappings in the config
  2. Develop a new config structure that will allow routed requests
  3. Drop persistent Metamask connection for a source chain, use only to send TXs instead

These changes will drastically simplify internal architecture, speed up Metaport usage and allow routed transfers in the Sandbox mode.

@dmytrotkk dmytrotkk added the enhancement New feature or request label May 29, 2023
@dmytrotkk dmytrotkk self-assigned this May 29, 2023
@dmytrotkk
Copy link
Contributor Author

Proposed config structure:

{
  "skaleNetwork": "mainnet",
  "autoLookup": true,
  "openButton": true,
  "chains": [
    "mainnet",
    "elated-tan-skat",
    "honorable-steel-rasalhague"
  ],
  "tokens": {
    "mainnet": {
      "eth": {
        "chains": [
          "elated-tan-skat",
          "adorable-quaint-bellatrix"
        ]
      },
      "erc20": {
        "_SKL_0x00c83aeCC790e8a4453e5dD3B0B4b3680501a7A7": {
          "address": "0x00c83aeCC790e8a4453e5dD3B0B4b3680501a7A7",
          "cloneAddress": "0xE0595a049d02b7674572b0d59cd4880Db60EDC50",
          "decimals": "18",
          "name": "SKALE",
          "symbol": "SKL",
          "chains": {
            "elated-tan-skat": {
              "type": "direct"
            },
            "honorable-steel-rasalhague": {
              "type": "routed",
              "hub": "elated-tan-skat",
              "tokenKeyname": "_SKL_0xD162bB5c75FE99144295b03510bAb2DF99617440",
              "tokenType": "erc20"
            }
          }
        }
      }
    },
    "elated-tan-skat": {
      "erc20": {
        "_SKL_0xD162bB5c75FE99144295b03510bAb2DF99617440": {
          "address": "0xD162bB5c75FE99144295b03510bAb2DF99617440",
          "cloneAddress": "0x4048C4dd6eccF1Dc23b068211fDf20AD19602e50",
          "decimals": "18",
          "name": "SKALE",
          "symbol": "SKL",
          "wraps": "0xE0595a049d02b7674572b0d59cd4880Db60EDC50",
          "chains": {
            "mainnet": {
              "type": "direct"
            },
            "honorable-steel-rasalhague": {
              "type": "direct"
            }
          }
        }
      }
    }
  },
  "theme": {
    "mode": "dark"
  }
}

@dmytrotkk dmytrotkk moved this to In Progress in SKALE Engineering 🚀 Jun 1, 2023
@dmytrotkk dmytrotkk added this to the 2.0.0 milestone Jun 14, 2023
@dmytrotkk dmytrotkk linked a pull request Sep 8, 2023 that will close this issue
@PolinaKiporenko PolinaKiporenko moved this from In Progress to Code Review in SKALE Engineering 🚀 Sep 15, 2023
@github-project-automation github-project-automation bot moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Sep 25, 2023
@PolinaKiporenko PolinaKiporenko moved this from Ready For Release Candidate to QA in SKALE Engineering 🚀 Oct 10, 2023
@yatsunastya
Copy link

No QA status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants