Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20TokenReceived event is emitted with wrong arguments #1295

Open
DimaStebaev opened this issue Oct 4, 2022 · 1 comment
Open

ERC20TokenReceived event is emitted with wrong arguments #1295

DimaStebaev opened this issue Oct 4, 2022 · 1 comment
Assignees
@DimaStebaev
Labels
bug Something isn't working

Comments

@DimaStebaev
Copy link
Contributor

https://github.com/skalenetwork/IMA/blob/1.3.4-beta.1/proxy/contracts/schain/TokenManagers/TokenManagerERC20.sol#L255

erc20OnSchain is almost always set to 0x0 except a first transfer.
@iamevansobeng
Copy link

Why not convert the whole repo to typescript? You'll catch all this in development

@DmytroNazarenko DmytroNazarenko added the bug Something isn't working label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimaStebaev DimaStebaev

Labels
bug Something isn't working
Projects
SKALE Engineering 🚀
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DimaStebaev @DmytroNazarenko @iamevansobeng