Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a change/edit button #340

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Adding a change/edit button #340

merged 3 commits into from
Jun 27, 2024

Conversation

thevijayshankersharma
Copy link
Contributor

@thevijayshankersharma thevijayshankersharma commented Jun 26, 2024 •
edited
Loading

Added a change/edit button to allow modifications while the disco simulator is running. This will enhance functionality and user control.

closes #182

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sk66641
Copy link
Owner

sk66641 commented Jun 26, 2024

@thevijayshankersharma
Issue #182 was supposed to add edit button which can edit inputs like number of colors, time interval & view

@thevijayshankersharma
Copy link
Contributor Author

@thevijayshankersharma Issue #182 was supposed to add edit button which can edit inputs like number of colors, time interval & view

I am unable to think of the logic for it. If you want, you can merge it for level 1, and the other guy can enhance this feature.

@sk66641
Copy link
Owner

sk66641 commented Jun 26, 2024

@thevijayshankersharma
ok but make the edit button only visible during the simulation & remove the add time & change music from the menu as you have included it in the "edit"

@thevijayshankersharma
Copy link
Contributor Author

@sk66641 Done

@sk66641 sk66641 merged commit 2c55250 into sk66641:main Jun 27, 2024
1 check passed
@sk66641 sk66641 added gssoc This Contribution is under GSSOC'24 level1 labels Jun 27, 2024
@sk66641 sk66641 mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thevijayshankersharma thevijayshankersharma

Labels
gssoc This Contribution is under GSSOC'24 level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a change/edit button
2 participants
@thevijayshankersharma @sk66641