Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Iceshrimp improvements #1000

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Iceshrimp improvements #1000

wants to merge 25 commits into from

Conversation

Jacocococo
Copy link

@Jacocococo Jacocococo commented Aug 21, 2024 •
edited
Loading

Lots of improvements to make the experience better on Iceshrimp. These include:

  • Improvements to emoji reactions
    • Enable reactions by default
    • Synchronize favorites and reacts (Except for on Iceshrimp.NET)
    • Respect max amount of reactions on a post (works for Glitch-Soc too)
    • Disable reaction buttons for remote reactions
    • Place the UI's reaction in the same place as the server has placed it
    • Fix bug where a new Unicode reaction wouldn't show up in the UI before refresh if the status previously had no reactions (not specific to Iceshrimp)
  • Improved quote posts support
    • It's now actually possible to quote a post from Iceshrimp
    • Adds another check to remove the RE: text
    • Fixes crash when viewing a quote post
    • Shows notification of the user's post getting quoted properly
  • Improved announcement display
    • Don't show emoji reactions
    • Correctly show edit time
  • Properly use content types since only MFM is supported
    • Disable settings by default and hide them (users will have to log out and in again to disable the setting if they want to. It shouldn't really matter, but that could possibly solve a problem someone is having after updating)
    • Allow all content types to lower risk of unexpected crashes (this fixes Editing a post on Iceshrimp crashes the app #998)
    • Set MFM as the default content type
  • Hide unsupported features
    • Account notify (Except for on Iceshrimp.NET. Doesn't seem to be supported on the server yet but likely will in the future)
    • News discovery
    • Language selector (Except for on Iceshrimp.NET. Not sure if it works currently, but I at least expect it to do in the future)
    • Filter settings
  • Load instance info immediately on main thread instead of in the background (too useful for it to be worth the unnoticable difference in app opening time)
  • Fix constant app crash after being logged into an Iceshrimp account for some time (see 86b6adf)

(I am aware that this project isn't currently active and don't expect much to be done with this PR in this repo. I started working on it a while ago (as seen in the commit dates) and decided I might as well finish it)

@Jacocococo
Quoting
53e8c0d
@Jacocococo
Don't load instance info in background
c8bb0de 
This information is very useful and it's loaded very quickly anyways
@Jacocococo
Hide news discovery on Iceshrimp
2892a31
@Jacocococo
Hide language selector on Iceshrimp
0e96e23
@Jacocococo
Fix Iceshrimp quote notification
325eda5
@Jacocococo
Hide profile notify button on Iceshrimp
454660f
@Jacocococo
Announcements fixes on Iceshrimp
3593d8d 
- Hide emoji reactions
- Correctly set editedAt
@Jacocococo
Respect instance max reaction count
86f54f5
@Jacocococo
Disable remote emoji reaction buttons on Iceshrimp
2dfb79c
@Jacocococo
Disable add reaction button upon reaching limit when using that button
6841649
@Jacocococo
Update favorite when reacting on Iceshrimp
2856e99
@Jacocococo
Move unauthenticatedApiController
86b6adf 
The constructor of AccountSessionManager may need this object which
could lead to a situation where it was being used before it had been
created.
Making it static and moving it to MastodonAPIRequest, the only place it
was being used anyways, seems to fix the issue.
@Jacocococo
Add reaction when favoriting post on Iceshrimp
3266a49
@Jacocococo
Add favorite reaction in right place + fix issues
1ad2257
@Jacocococo
Fix unicode reaction not showing up if no reactions were previsouly p…
5f78cd4 
…resent
@Jacocococo
Fix crash when liking statuses from non-Iceshrimp instances
309d272
@Jacocococo
Place new reaction where server specified it
5d411e8
@Jacocococo
Prevent more reactions if max has been reached
6a46815 
This is specifically for tapping existing reactions on a post if the
user has already reached the instance max
@Jacocococo
Only allow MFM content type on Iceshrimp
cd7c546
@Jacocococo
Disable content type setting on Iceshrimp
96b9920 
We can be sure it doesn't support anything other than MFM
@Jacocococo
Allow all content types on Iceshrimp
893b883 
It's disabled anyways for new users, and allowing all lowers the chance
of crashes from a previously selected option being missing
@Jacocococo
Hide filter settings on Iceshrimp
c834199
@Jacocococo
Revert some changes specifically for Iceshrimp.NET
4078443
@Jacocococo Jacocococo mentioned this pull request Aug 22, 2024
Open
@Jacocococo
Change isAkkoma to be based on version code
465dbed 
Iceshrimp.NET now also implements some APIs using the pleroma field, so
only checking for that would create false positives for Iceshrimp.NET
@Jacocococo
Don't hide filter settings on Iceshrimp.NET
4070592
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editing a post on Iceshrimp crashes the app
1 participant
@Jacocococo