Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AccountSession): load custom emoji with auth from GTS #528

Closed
wants to merge 1 commit into from

Conversation

FineFindus
Copy link

GoToSocial requires authentication for requesting the emoji list.

Closes sk22#989

Since I don't have a GTS account, I was unable to verify if this works.

GoToSocial requires authentication for requesting the emoji list.

Closes sk22#989
@cdn0x12
Copy link

cdn0x12 commented Sep 11, 2024

I tested this PR with my GoToSocial account. When requesting the /api/v1/custom_emojis endpoint, GoToSocial still returns a 401 error, displaying errors=Error #01: token not supplied\n

I changed the version number, and the version number displayed in the final built APK also changed, so I guess my build process is fine.

Maybe we don't need to check if the user's instance is GoToSocial? As far as I know, making a request to the custom emoji endpoint of a Mastodon instance with an Auth Token doesn't have side effects. Also, it seems that Mastodon instances with AUTHORIZED_FETCH enabled require an access token when requesting the custom emoji endpoint.

I'm willing to continue testing this PR or provide a corresponding GoToSocial account for further testing.

@FineFindus
Copy link
Author

mastodon#948

@FineFindus FineFindus closed this Dec 19, 2024
@FineFindus FineFindus deleted the fix/gts-emoji branch December 19, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom emojis don't work with gotosocial
2 participants