Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 upload with SigV4 broken #1689

Closed
fbusse opened this issue Aug 3, 2017 · 6 comments
Closed

S3 upload with SigV4 broken #1689

fbusse opened this issue Aug 3, 2017 · 6 comments
Labels

Comments

@fbusse
Copy link

fbusse commented Aug 3, 2017

Uploading to S3 in newer regions[1] that need v4 authentication is not possible.
This happens when with sitespeed 5.4.4:

ERROR: Could not upload to S3 Error: Non-file stream objects are not supported with SigV4 in AWS.S3
at Request.computeSha256 (/usr/src/app/node_modules/aws-sdk/lib/services/s3.js:200:18)

[1] http://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region

@beenanner
Copy link
Member

@fbusse thanks for reporting will take a look soon.

@beenanner beenanner added the bug label Aug 3, 2017
@soulgalore
Copy link
Member

so if I wanna try this, do we know which region? maybe we just need to upgrade the s3 plugin?

@fbusse
Copy link
Author

fbusse commented Nov 25, 2017

@soulgalore Sorry if you were waiting for a response from me: My test was with eu-central-1.
All new regions use SigV4.

@soulgalore
Copy link
Member

@beenanner started to look at this but not sure why it's not working (removed my branch since it uses v4 per default). let me know if you have any idea.

@soulgalore
Copy link
Member

Seems to be that the s3 module we use hasn't been updated with the latest aws-sdk andrewrk/node-s3-client#175

soulgalore added a commit that referenced this issue Dec 12, 2017
soulgalore added a commit that referenced this issue Dec 12, 2017
@soulgalore
Copy link
Member

This was released a couple of releases ago (by using the aws code directly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants