-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface with POMDPs belief updaters #38
Comments
I think this is en excellent idea and I believe it has been discussed before but nobody has found time to do it so far. If you have some spare cycles I'd be glad to review a PR on this. |
I just did some superficial browsing of the source code and it seems that would have to make a semi-breaking change to move from I'm wondering whether we should use the opportunity (before POMDPs 1.0) to factor out the belief updater abstraction into its own package. This at least would make it easier to also convince other belief updater packages to implement that interface without having to pull in a dependency on the full POMDPs.jl package; e.g. LowLevelParticleFilters.jl (cc @zsunberg) |
Hmmm... why would switching to I don't think POMDPs.jl is too heavy of a dependency. Its dependencies are pretty light https://github.com/JuliaPOMDP/POMDPs.jl/blob/master/Project.toml, and if someone wants to make a belief updater that works for a POMDP, they will need to import I think it is better to keep |
The ParticleFilters.jl package is excellent because it can also interface with the POMDPs belief updaters—I'm wondering if this is something you've intended for this package too.
The text was updated successfully, but these errors were encountered: