-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use custom jacobian implementation. #21
Comments
@lassepe just out of curiosity, can the performance problems of ForwardDiff be avoided by the user by them implementing a method of jacobian? or does that not work because of the |
The latter is the case. |
Also, this would not be very desirable because the user might want to use another AD tool like Zygote. It would be very weird for the user to write a version of |
right - that makes a lot of sense |
For prototyping,
ForwardDiff.jacobian
is very good but it still allocates significantly more memory than a hand-written Jacobian.GaussianFilters.jl/src/ekf.jl
Line 26 in bc24efe
GaussianFilters.jl/src/ekf.jl
Line 73 in bc24efe
I think the user should be allowed to overload these functions by implementing something like
GaussianFilters.linear_obsmodel
andGaussianFilters.linear_dynamics
. You can provide a default implementation based inForwardDiff.jacobian
of these methods and for the linear cases, you can provide a simple identity. By this means, you can avoid the manual type checking and let dispatch do the magic.The text was updated successfully, but these errors were encountered: