Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project.toml to fix issue #36 #37

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Update Project.toml to fix issue #36 #37

merged 2 commits into from
Feb 16, 2024

Conversation

elsoroka
Copy link
Contributor

No description provided.

@mykelk
Copy link
Member

mykelk commented Feb 15, 2024

It looks like it is failing on Julia 1.0. Can you add to this PR a revision to the Project.toml that specifies the appropriate minimum Julia version and update .github/workflows/CI.yml with that minimum version as well? If not, let me know and I'll try to get to it soon. Thanks so much!

@mykelk
Copy link
Member

mykelk commented Feb 15, 2024

I think it is probably fine to go with Julia 1.6 (which is LTS).

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@mykelk mykelk merged commit c08a8bb into sisl:master Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants