Use File::getMethodParameters()

[jrfnl]

phpcs-variable-analysis/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php

Lines 464 to 467 in 2976bca

	// Are we a function or closure parameter?
	// It would be nice to get the list of function parameters from watching for
	// T_FUNCTION, but AbstractVariableSniff and AbstractScopeSniff define everything
	// we need to do that as private or final, so we have to do it this hackish way.

I have no clue how old that comment is, but it definitely isn't valid anymore and hasn't been valid for a long time.

The File::getMethodParameters() utility method can retrieve information on all declared parameters for functions, closures (since PHPCS 2.8.0), arrow functions (since PHPCS 3.5.4) and closure use statements (since PHPCS 3.5.0).

Ref: https://pear.php.net/package/PHP_CodeSniffer/docs/3.5.4/apidoc/PHP_CodeSniffer/File.html#methodgetMethodParameters

To change this would probably require a refactor, but it would also make the code more stable and simpler.

[sirbrillig]

It looks like it originated in 2011 here: 385b5a8

Sounds like a great idea to replace that.

[jrfnl]

As that would require a refactor and the issue with lists would also be better off with a refactor (and I can think of some additional issues with global and static), we may want to set up a call at some point to discuss how to approach this and who will take care of what, including the implementation of using PHPCSUtils.

[sirbrillig]

That sounds like a good idea. A lot of the code in this sniff has been implemented in a "make the tests pass and we can clean it up later" manner, and I think adding PHPCSUtils is an excellent opportunity to do a lot of that clean up.

This week I'm working on launching a major project at work which is taking up pretty much all of my time but I'd love to chat about this in more detail after we're done... maybe next week or the week after?

[jrfnl]

I'm prepping for a conference at the moment (or rather: should be) and will be traveling and such for the next two weeks after that. So, realistically, any time after March 9th ;-)

[jrfnl]

If you want to have a look at what PHPCSUtils offers in the mean time, the documentation is up: https://phpcsutils.com/ and https://phpcsutils.com/phpdoc/index.html