Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Detection from Microsoft Edge Version returns the HTML Version #77

Open
DustinUtecht opened this issue Apr 4, 2017 · 3 comments
Open

Detection from Microsoft Edge Version returns the HTML Version #77

DustinUtecht opened this issue Apr 4, 2017 · 3 comments
Labels
bug
Milestone
7.0.0

Comments

@DustinUtecht
Copy link

If i detect the Browser Version from Edge it returns 14 (Html Version) instead of 38 (Edge Version).
@gabrielbull
Copy link
Member

Can you post your user agent string so we can add a unit test?

@DustinUtecht
Copy link
Author

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393"

@gabrielbull
Copy link
Member

14.14393 is the version marked in this user agent string.

From this wiki, this is the EdgeHTML version, there is a table there that could be used to convert EdgeHTML version to Edge version.

TomMettam added a commit to CasperTech/php-browser-detector that referenced this issue Apr 6, 2017
@TomMettam
Issue sinergi#77 - Detection from Microsoft Edge Version returns the …
235a2a8 
…HTML Version

This adds a lookup table for Edge. This will require some maintenance.

If the version cannot be resolved, the browser name "EdgeHTML" is returned rather than "Edge", so that the version number is not misleading.

Also fixed regex for edge.
@TomMettam TomMettam mentioned this issue Apr 6, 2017
Merged
@gabrielbull gabrielbull added this to the 7.0.0 milestone Apr 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@gabrielbull @DustinUtecht