Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of connected_nodes during the refactoring #11

Open
4 tasks done
Tracked by #296
antonykamp opened this issue Apr 13, 2023 · 0 comments · May be fixed by #12
Open
4 tasks done
Tracked by #296

Replace usage of connected_nodes during the refactoring #11

antonykamp opened this issue Apr 13, 2023 · 0 comments · May be fixed by #12

Comments

@antonykamp
Copy link

antonykamp commented Apr 13, 2023 •
edited
Loading

During the refactoring See simulate-digital-rail/yaramo#40 we have to replace writing access of connected_nodes with connected_edges and edit calls of set_connection_left, set_connection_right and set_connection_head to take edges instead of nodes.

Acceptance criterion

  • Replace writing access of connected_nodes with connected_edges
  • Give set_connection_left the edge instead of a node
  • Give set_connection_right the edge instead of a node
  • Give set_connection_head the edge instead of a node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: Replace connected_nodes connected_edges BP2022-AP1/planpro-importer
1 participant
@antonykamp