Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratelimiting 'support' #38

Open
lieuwex opened this issue Nov 30, 2015 · 3 comments
Open

Ratelimiting 'support' #38

lieuwex opened this issue Nov 30, 2015 · 3 comments

Comments

@lieuwex
Copy link
Member

lieuwex commented Nov 30, 2015

Magister has added rate limiting a little while ago, and we currently just straight up ignore it. When ratelimited Magister sends an object like: {"Message":"Rate limit reached. Reset in 25 seconds.","SecondsLeft":25}.

I was thinking about when we get an object with a SecondsLeft field we delay every set request and repeat the current one (where we get the error from) after the value of SecondsLeft.
For this we need to wrap the HTTP object (as said in #29).

@lieuwex lieuwex modified the milestone: 2.0 Dec 18, 2015
@tomsmeding
Copy link
Member

Yay for straight-up ignoring

@lieuwex
Copy link
Member Author

lieuwex commented May 23, 2016

That tactic hasn't been really working for us to be honest

@lieuwex
Copy link
Member Author

lieuwex commented Jul 26, 2016

I think this is done on the v2 branch, still have to test it, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants