Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable repoclosure for modular repos #217

Closed
op-ct opened this issue Aug 7, 2024 · 0 comments · Fixed by #218
Closed

Disable repoclosure for modular repos #217

op-ct opened this issue Aug 7, 2024 · 0 comments · Fixed by #218

Comments

@op-ct
Copy link
Member

op-ct commented Aug 7, 2024

The iso:build repoclosure is presently unskippable, and doesn't work with modular repos. In fact, it probably never can: https://bugzilla.redhat.com/show_bug.cgi?id=1547041

There should be a way to disable the repoclosure check during iso builds to avoid spurious errors

@op-ct op-ct added this to Org Triage Aug 7, 2024
op-ct added a commit to op-ct/rubygem-simp-rake-helpers that referenced this issue Aug 7, 2024
The `iso:build` repoclosure task is presently unskippable, but
`repoclosure` itself doesn't work with modular repos. In fact, it
probably never can: https://bugzilla.redhat.com/show_bug.cgi?id=1547041

This patch disables the repoclosure step by default, and adds an
environment variable, `SIMP_BUILD_repoclosure` to reenable it when set
to `yes`.
@op-ct op-ct closed this as completed in #218 Aug 9, 2024
@github-project-automation github-project-automation bot moved this from New to Done in Org Triage Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant