Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ever considered using windows-process-tree? #6

Open
atrauzzi opened this issue Aug 9, 2018 · 5 comments
Open

Ever considered using windows-process-tree? #6

atrauzzi opened this issue Aug 9, 2018 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@atrauzzi
Copy link

atrauzzi commented Aug 9, 2018

Just happened upon this and I figured it might be neat if this package wrapped/abstracted it. This is made by Microsoft, so it's a pretty decent option for a solid reference implementation...

https://github.com/Microsoft/vscode-windows-process-tree

Anyway, love this lib, thank you so much!

cc. indexzero/ps-tree#31 (comment)

@huan huan added the enhancement New feature or request label Aug 9, 2018
@huan
Copy link
Collaborator

huan commented Aug 9, 2018

It would be awesome that we can use a module from Microsoft to do this.

Would you like to send a PR so that we can start to discuss based on the code?

@atrauzzi
Copy link
Author

atrauzzi commented Aug 9, 2018

I'm not intimately familiar with this library or the Microsoft one, I'm not sure when I'll have time to make an attempt (I'd really love to).

At the very least, let's let this issue serve as a bookmark for the future. Whether I get to it first or you guys do...

@huan huan added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 9, 2018
@huan
Copy link
Collaborator

huan commented Aug 9, 2018

Ok, would love to hear back from you in the future!

@simonepri
Copy link
Owner

@atrauzzi we will definitely give it a try, the speed improvement should be really significative!

@soyuka
Copy link
Collaborator

soyuka commented Aug 9, 2018

this would definitely be a nice improvement! It'd even be better if they could add some metrics to that call so that we stop using wmic (it's sooo slow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants