-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for URL escaped {{ }} in lenses #165
Comments
Sorry Pike; missed this notification. |
Here's my path to it, I use django to generate the URL, which ends up in iri_to_uri, https://github.com/django/django/blob/92053acbb9160862c3e743a99ed8ccff8d4f8fd6/django/utils/encoding.py#L169, which points to https://tools.ietf.org/html/rfc3987#section-3.1, which then has the paragraph
I really feel that we're battling one edgecase vs the other. Is that something one could make configurable? Otherwise I might be stuck with either patching django or patching exihibit :-/ |
I'm using django to create URLs for exhibit lenses, and that does a iri_to_url, which url-escapes the {{ }} that I passed in.
I'm currently working around that by decodeURI() on the value in the subcontent parser:
@karger, do you have an opinion on whether this is good for exhibit to do or not?
The text was updated successfully, but these errors were encountered: